Size: a a a

2020 March 27

AS

Alexander Sushko in Moira
Harshit Verma
@sashasushko i guess upgrading react-router has broken the code. Just try to add a trigger, you will notice useHistory() not defined error.
источник

AS

Alexander Sushko in Moira
Harshit Verma
@sashasushko i guess upgrading react-router has broken the code. Just try to add a trigger, you will notice useHistory() not defined error.
My bad, I not check pull request with more attention. Thank you!
источник

HV

Harshit Verma in Moira
i think useHistory is used outside the react-router root element
источник

AS

Alexander Sushko in Moira
Harshit Verma
i think useHistory is used outside the react-router root element
No. It's because it was used in class component methods
источник

HV

Harshit Verma in Moira
Alexander Sushko
No. It's because it was used in class component methods
ohkay! 👍
источник

AS

Alexander Sushko in Moira
@hv7214 can you look at my pull request, please?
источник

AS

Alexander Sushko in Moira
источник

HV

Harshit Verma in Moira
Sure : )
источник

AS

Alexander Sushko in Moira
Harshit Verma
Sure : )
Thanks
источник

HV

Harshit Verma in Moira
Alexander Sushko
@hv7214 can you look at my pull request, please?
go ahead, everything seems good
источник

AS

Alexander Sushko in Moira
Harshit Verma
go ahead, everything seems good
Merged.
источник

AS

Alexander Sushko in Moira
Please update your branch
источник

HV

Harshit Verma in Moira
Alexander Sushko
Please update your branch
sure
источник
2020 March 28

E

Edit Name in Moira
Alexey Kirpichnikov
Dear potential GSoC participants! We have some introductory issues for new contributors left over from last year. Mostly frontend right now. You can take any issue in the Available column on this board: https://github.com/orgs/moira-alert/projects/2 and try to fix it.
Hi, everyone! I found this channel difficult. I wanted to choose moira for GSOC. Be sure to write the best golang code for Moira.
источник
2020 March 29

AJ

Akshat Jain in Moira
Hello everyone!
I'm Akshat Jain, a pre-final year undergraduate student pursuing CSE at IIT Patna, India. I did my first GSoC with FOSSASIA in my freshman year. I know I'm a little late but I'm interested in participating in GSoC with Moira, particularly on the idea "Health checks for delivery channels and contacts". I understand the importance and the use case of this idea and I'm extremely interested in working on this. I am extremely comfortable with React.js and have decent knowledge of Go as well.
I have already setup Moira on my local machine too and successfully tried feeding data to localhost:2003 in Graphite format and tinkering with it by creating triggers, subscriptions, and delivery channels on localhost:8080. I've also given a quick look over the codebase to understand the basic workflow and I was hoping to know if there's anything else I should be knowing.
I haven't made any substantial contribution yet to Moira but am extremely looking forward to working with the community if given the opportunity. Thanks! :)
источник

SB

Saad Bazaz in Moira
Hello, everyone!
I am Saad Bazaz, a second year student in FAST University Islamabad. This is my first time applying to GSoC, and I had a hard time navigating through the process (specially setting up the dev environment). I would really really appreciate some help (https://github.com/moira-alert/moira/issues/524). I have some ideas to implement in Moira but due to this I cannot execute them!
Best regards,
источник

HV

Harshit Verma in Moira
Saad Bazaz
Hello, everyone!
I am Saad Bazaz, a second year student in FAST University Islamabad. This is my first time applying to GSoC, and I had a hard time navigating through the process (specially setting up the dev environment). I would really really appreciate some help (https://github.com/moira-alert/moira/issues/524). I have some ideas to implement in Moira but due to this I cannot execute them!
Best regards,
Hi, regarding your last concern about notifier_1: did you registered your sender in notifier.yml file ? I guess not
источник

SB

Saad Bazaz in Moira
You're right, I haven't done that.
I've now copied and pasted the senders in the Docs, into my local YAML.
Should I make build again, or docker-compose?
источник

HV

Harshit Verma in Moira
Just remove the notifer image and do docker-compose up
источник

SB

Saad Bazaz in Moira
I'm sorry if this is a very noob question...
Where would the notifier image be?
And am I doing the rest of the process correctly? When using Docker, do I need to build and run the microservices using make?
источник