\o/

🔌 New pull request chat-linker#69 fix dockerfile to use local commits, and add docker-compose file :)
by: @albjeremias



Reply to this message to post a comment on GitHub.

💬 New comment on chat-linker#62 Not all types of messages are translated from Telegram
by @albjeremias

Hi, I was checking a bit this thing.
I have no idea what this file is about:
https://github.com/jt3k/chat-linker/blob/master/flow-typed/telegraf_vx.x.x.js

the bot should be able to handle images... https://github.com/telegraf/telegraf/blob/develop/docs/examples/media-bot.js but this abstraction of the telegraf makes it more complicated? I need a hint

Reply to this message to post a comment on GitHub.

@ajeremias telegraf_vx.x.x.js is typings (lib definitions) for telegraf

hmm can you pass me some how-to/tutorial on it?

💬 New comment on chat-linker#69 fix dockerfile to use local commits, and add docker-compose file :)
by @ForNeVeR

I'm okay with the idea, but I'd like to discuss the volume thing.

Reply to this message to post a comment on GitHub.

💬 New comment on chat-linker#62 Not all types of messages are translated from Telegram
by @ForNeVeR

That's our own flow definitions for the telegraf library. You should be able to extend them if you need any additional stuff from Telegraf.

We wasn't able to found any official or external flow definitions for it, so we had to roll out our own.

Probably (I'm not sure because I'm not a flow expert yet) it will work even without them. Check yourself :)

Reply to this message to post a comment on GitHub.

💬 New comment on chat-linker#68 support multiple rooms between telegram and xmpp
by @ForNeVeR

Wow, really interesting stuff. Are you done yet? Should I review?

Reply to this message to post a comment on GitHub.

У нас раньше была проблема с тем, что если пользователь отправит метасимволы типа $$ $` $&, то они некорректно отправятся в телеграм.
Видимо, это исправили только частично, только для xmpp -> telegram. В telegram -> xmpp метасимволы все еще неправильно отправляются. @fvnever

А пример есть?

отправил в @javascript_ru пример

http://chatlogs.jabber.ru/javascript@conference.jabber.ru/2018/08/19.html в логах джаббера сообщение иначе показвыается

💬 New comment on chat-linker#59 Some messages break the template
by @ForNeVeR

Please fix in XMPP code, too: https://github.com/jt3k/chat-linker/blob/a755932413c385bf98d17e247dabc0591d08de4d/src/bots/jabber/bot.js#L23

Reply to this message to post a comment on GitHub.

Ок, починим.

💬 New comment on chat-linker#68 support multiple rooms between telegram and xmpp
by @albjeremias

yeah, its done... :) i have been testing it for the last few days... please feel free to comment on how the config should look like... this version will break the current config...

Reply to this message to post a comment on GitHub.

🔨 2 new commits to chat-linker:master:

7194267: fix dockerfile to use local commits, and add docker-compose file :) by Albatroz Jeremias
00b2c6e: fix docker-compose image name by Albatroz Jeremias

💬 New comment on chat-linker#68 support multiple rooms between telegram and xmpp
by @albjeremias

@ForNeVeR i cannot find any place where i can assigne it back to u...

Reply to this message to post a comment on GitHub.

💬 New comment on chat-linker#68 support multiple rooms between telegram and xmpp
by @ForNeVeR

Sorry? I've assigned it to myself and I'll review/merge when I'll be able to.

Reply to this message to post a comment on GitHub.

💬 New comment on chat-linker#68 support multiple rooms between telegram and xmpp
by @jt3k

Wonderful code editing, thanks!

I had thoughts about the configuration scheme for connecting multiple chats here #3 (maybe outdated)
I assumed that we would someday want to connect for example two xmpp-conferences of one network,
Or for example 3 chat rooms at the same time [xmpp_coders, xmpp_python, telegram_coders]

so I think that the config should look something like this:

{ 
  networks: { 
    xmpp_python: { /* net configs */}, 
    xmpp_coders: {}, 
    tg_coders: {}, 
    tg_js: {}, 
    xmpp_js: {}, 
  }, 
  links: [ 
    ['xmpp_python', 'xmpp_coders', 'tg_coders'], // linked chats 
    ['xmpp_js', 'tg_js'], // another linked chats 
  ], 
} 

any ideas on this ?
(perhaps not in this pull-request)

Reply to this message to post a comment on GitHub.

💬 New comment on chat-linker#68 support multiple rooms between telegram and xmpp
by @albjeremias

hmm I'd rather go for something more simple... like:

{ 
  "rooms": 
  { 
      "dev": [ 
      { 
        "xmpp": ["bimo_test@conference.jabber.ru", "otherroom@conference.com"] 
        "telegramId": -310606513 
      }, 
      { 
        "xmpp": "javascript@conference.jabber.ru", 
        "telegramId": [-1001161009393, -162979832132] 
      } 
      ], 
      "prod": [] 
  }, 

and on the code we could detect if it is an array... then we do what we need to do... but that complicates a lot the bridging.. and may create funky bugs... i'd rather duplicate the configurations something like:

  "rooms": 
  { 
      "dev": [ 
      { 
        "xmpp": "otherroom@conference.com" 
        "telegramId": -310606513 
      }, 
      { 
        "xmpp": "otherroom@conference.com" 
        "telegramId": -310606513 
      }, 
      { 
        "xmpp": "javascript@conference.jabber.ru", 
        "telegramId": -1001161009393 
      } 
      { 
        "xmpp": "javascript@conference.jabber.ru", 
        "telegramId": -162979832132 
      } 
      ], 
      "prod": [] 
  }, 

the bigger problem... is that this new way of config will make previous configs unusable... that worries me more...

Reply to this message to post a comment on GitHub.